fix: improve connectivity HTML if quota info error#8130
Conversation
WofWca
changed the title
WofWca
force-pushed
the
wofwca/quota-error-html
branch
from
80ea722 to
ca807dc
Compare
| Err(e) => { | ||
| ret += &escaper::encode_minimal(&e.to_string()); | ||
| // TODO translate "Quota". | ||
| ret += &format!("Quota: {}", &*escaper::encode_minimal(&e.to_string())); |
There was a problem hiding this comment.
Maybe add a stock str with a function that takes the encoded error as an argument? And UIs will translate it later
|
Maybe better just not display anything at all if quota is not supported? User cannot do anything about it, they will have to see "Quota: Not supported by your provider." below each transport that does not support it. |
|
Good idea. Though I guess we would still want to display the text if it's a different kind of error? |
|
quota anyway becomes less interesting now that relays auto-expire messages to keep users always under quota. Just not showing anything if there is no quota info is fine. |
This also solves the problem with the fact that it's not clear from the resulting HTML that this error message is referring to quota and not something else. See #8130.
Currently if there is an error getting quota the HTML displays something like ``` example.com: Connected Failed to parse. ``` It's not clear that "Failed to parse" only refers to quota info.
WofWca
force-pushed
the
wofwca/quota-error-html
branch
from
ca807dc to
2aa96e2
Compare
|
OK, #8247 is merged. But I still think that displaying "Quota: " in case of any other error is nice. Seems like we're in doubt about whether it's that nice, so I haven't turned this into a translatable string. |
4 participants
Currently if the provider doesn't support quota info
the HTML displays something like
It's not clear that "not supported" only refers to quota info.