Fix RabbitMQ runtime credentials#397
Conversation
deepanshutiwari27
force-pushed
the
codex/fix-issue-278
branch
from
624f516 to
bb4b735
Compare
MoralCode
left a comment
MoralCode
left a comment
There was a problem hiding this comment.
Thanks for taking on this issue! Unfortunately this is a little more complex than changing build args to environment cars because of this config file.
Happy to chat solutions if you get stuck!
| RUN exec python3 update_config.py | ||
| RUN chmod +x /collectoss-rabbitmq-entrypoint.sh |
There was a problem hiding this comment.
This won't work. This script runs at build time and is the same as the entry point script. Its going to bake a config file into the container containing a hash of the default password (because a different password isnt provided at build time)
There was a problem hiding this comment.
Can we Keep the runtime wrapper, but remove RUN chmod +x and invoke it with /bin/sh. This makes config generation visibly runtime-only and keeps the image portable.
There was a problem hiding this comment.
@MoralCode Can you please guide me what needs to be done further
deepanshutiwari27
force-pushed
the
codex/fix-issue-278
branch
4 times, most recently
from
fccef95 to
bc4ed97
Compare
Signed-off-by: Deepanshu Tiwari <[email protected]>
Signed-off-by: Deepanshu Tiwari <[email protected]>
deepanshutiwari27
force-pushed
the
codex/fix-issue-278
branch
from
bc4ed97 to
9aab022
Compare
2 participants
Change rabbit mq variables from build time to runtime by changing it from args to environment variables
Fix issue #278