docs(audits): explain why audit checks duplicate real-time validation - #1725
docs(audits): explain why audit checks duplicate real-time validation#1725kaligrafy wants to merge 3 commits into
Conversation
|
Caution Review failedAn error occurred during the review process. Please try again later. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
greenscientist
left a comment
There was a problem hiding this comment.
Frankly I feel you are going into too much details here. I don't feel this is useful to add
En fait, je pense que c'est utile, car n'importe qui pourrait se poser la même question que toi: pourquoi les audits + validations temps réel, et donc ça explique pourquoi et ça relance le TODO de convertir tout en objets dans le frontend aussi. Si tu pense que c'est vraiment pas nécessaire, on peut rejeter cette PR. |
Audit checks re-validate data regardless of frontend validation because a respondent can leave a field invalid without correcting it, or edit the stored interview data directly, bypassing real-time validation entirely.
Once survey objects are unified between frontend and backend and persisted as separate DB columns per attribute, most audit checks could be reused directly as real-time validations, removing the current duplication.
…udits" This reverts commit db02720.
84fa965 to
2f813f7
Compare
Summary
packages/evolution-backend/src/services/audits/README.md; more complete version with the two scenarios added topackages/evolution-backend/src/services/audits/auditChecks/README.md, linked from the short one.No code changes — documentation only.
Test plan
auditChecks/README.md#1-what-is-an-audit-check) resolves correctly on GitHubSummary by CodeRabbit