Skip to content

sync readline and console with upstream#1

Open
M09Ic wants to merge 2 commits into
masterfrom
chore/sync-readline-console-upstream
Open

sync readline and console with upstream#1
M09Ic wants to merge 2 commits into
masterfrom
chore/sync-readline-console-upstream

Conversation

@M09Ic

@M09Ic M09Ic commented Jun 27, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • Sync embedded readline with official upstream 088046b via git merge result 916e20f.
  • Sync embedded console with official upstream 7002774 / v0.3.1 via git merge result 92517a0.
  • Preserve the local tui fork capabilities: terminal abstraction, remote/custom IO, paste references, inline suggestions, clipboard integration, terminal-aware console output, exported Console.Execute, and completion state hardening.
  • Add docs/readline-console-upstream-sync.md documenting the recurring upstream sync workflow.
  • Add fork regression tests so future upstream syncs fail if local terminal/paste/inline suggestion/Execute capabilities are removed.

Tests

  • PASS: go test ./... in D:\Programing\go\chainreactors\tui\readline
  • PASS: go test ./... in D:\Programing\go\chainreactors\tui\console
  • FAIL: go test ./... in D:\Programing\go\chainreactors\tui
    • Existing root package vet failures: non-constant format string in fmt.Printf calls.
    • Existing example build failure: example/kvtable/main.go calls tui.RenderKV with the old argument list.

Fork regression coverage

  • readline/fork_test.go: custom terminal input/output and inline suggestion API.
  • readline/terminal/fork_test.go: stream control size and resize callback behavior.
  • console/fork_test.go: NewWithTerminal, terminal-aware output, exported Execute, and inline suggestion bridge.
  • Existing console/paste_test.go: paste reference behavior.

Notes

  • Official readline and console now use go 1.25.0; the tui root module remains go 1.24.2.
  • The root test failures are outside readline / console and were not mixed into this sync PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant