sync readline and console with upstream#1
Open
M09Ic wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
readlinewith official upstream088046bvia git merge result916e20f.consolewith official upstream7002774/v0.3.1via git merge result92517a0.Console.Execute, and completion state hardening.docs/readline-console-upstream-sync.mddocumenting the recurring upstream sync workflow.Tests
go test ./...inD:\Programing\go\chainreactors\tui\readlinego test ./...inD:\Programing\go\chainreactors\tui\consolego test ./...inD:\Programing\go\chainreactors\tuifmt.Printfcalls.example/kvtable/main.gocallstui.RenderKVwith the old argument list.Fork regression coverage
readline/fork_test.go: custom terminal input/output and inline suggestion API.readline/terminal/fork_test.go: stream control size and resize callback behavior.console/fork_test.go:NewWithTerminal, terminal-aware output, exportedExecute, and inline suggestion bridge.console/paste_test.go: paste reference behavior.Notes
readlineandconsolenow usego 1.25.0; the tui root module remainsgo 1.24.2.readline/consoleand were not mixed into this sync PR.