test(permissions): carry the root id column in the parity scratch table#876
Merged
Conversation
The config-adaptive parity test claims to run on any fork config, but its scratch table lacked the root id column. Forks that configure elevatedRoles compile home-scoped grants against it (organization_id), so on any such fork the test threw instead of verifying parity. Derive the column from entityIdColumnKeys like the sub-context column; on the template config it is simply never referenced. Found by projectcampus (first elevatedRoles consumer); fix ported verbatim from its fork-side patch. Co-Authored-By: Claude Fable 5 <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The config-adaptive parity test (#866) claims to run on any fork config, but its scratch table lacked the root id column. Forks that configure
elevatedRoles(#873) compile home-scoped grants against it (organization_id), so on any such fork the test threw at SQL compile time instead of verifying parity.Fix: derive the root id column from
entityIdColumnKeysexactly like the existing sub-context column, add it to the scratch table (NOT NULL) and to row seeding. On the template config the column is simply never referenced — behavior-identical.Found by projectcampus (first
elevatedRolesconsumer); ported verbatim from its fork-side patch, which is already verified in its CI.🤖 Generated with Claude Code