Feat/mcp oauth auth server#869
Draft
flipvh wants to merge 3 commits into
Draft
Conversation
…eriment 0) Add an in-process OIDC Authorization Server (panva/node-oidc-provider) mounted at /oauth, and switch the MCP endpoint from session-cookie auth to OAuth bearer JWT validation. Gated behind AUTH_SERVER_ENABLED (default off) so the template default is unchanged. - auth-server module: node-oidc-provider bridged into Hono via the raw node req/res + RESPONSE_ALREADY_SENT; Authorization Code + PKCE, client_credentials, and resource-indicator JWT access tokens bound to the MCP resource (dev-only in-memory adapter / devInteractions / DCR). - mcpAuthGuard: jose JWKS verification (issuer/audience/scope), maps the token subject to a Cella user and sets the context tenantGuard/orgGuard need; fails closed (401) on a bad/unknown subject. - RFC 9728 protected-resource metadata + WWW-Authenticate challenge. - MCP advertises mcpBearerAuth (HTTP bearer) instead of cookieAuth. - whoami demo tool (flag-gated) so tools/call returns a real identity. - 7 guard tests; MCP_PLAN.md rewritten into actionable phase checklists. Co-Authored-By: Claude Opus 4.8 (1M context) <[email protected]>
…(phase 2+3) Phase 3 — service identity: - Add an McpActor concept (core/context.ts). A client_credentials token (sub === client_id, no user) is authorized as a service actor via an allowlist (MCP_SERVICE_CLIENT_IDS) plus its audience-bound tenant/org. The guard synthesizes a membership scoped to exactly that tenant/org so the shared tenantGuard/orgGuard authorize it without changes. - whoami now reports actorType (user|service). Verified end-to-end: a service token flows through the full guard chain and reaches tools/call. Phase 2 — resource-server hardening: - Harden the remote JWKS fetch (timeout / cooldown / cacheMaxAge). - Add root /.well-known/oauth-protected-resource alongside the per-tenant/org document. Also: +2 guard tests (allowlisted service actor passes; rogue client 403). Co-Authored-By: Claude Opus 4.8 (1M context) <[email protected]>
…se 1) Harden the Authorization Server so it survives restarts and drops the dev-only shortcuts. - Postgres storage adapter (oidc-adapter.ts): one generic oidc_payloads table keyed by (type, id), indexed on grant/uid/user_code/expires, bootstrapped with CREATE TABLE IF NOT EXISTS on the BYPASSRLS admin connection and wired via the provider `adapter` option. Clients, grants, sessions, codes and refresh/registration tokens now persist. Verified: a DCR client + registration token survive a fresh process. - findAccount resolves the OIDC subject against usersTable (sub/email/name claims); unknown subjects fail login. - Require a stable OIDC_PRIVATE_JWK outside development/tunnel; gate devInteractions, open DCR and the pre-registered dev clients to dev. Remaining before production (tracked in MCP_PLAN.md): key rotation, first-party consent UI, modeled OAuth tables + expiry sweeper. Co-Authored-By: Claude Opus 4.8 (1M context) <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.