gate ML‑KEM/ML‑DSA specific SHA3 APIs behind optional features (#1532)#1542
Open
Arul-Sujith wants to merge 3 commits into
Open
gate ML‑KEM/ML‑DSA specific SHA3 APIs behind optional features (#1532)#1542Arul-Sujith wants to merge 3 commits into
Arul-Sujith wants to merge 3 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR gates the ML‑KEM and ML‑DSA specific SHA3 APIs behind optional Cargo features (
mlkemandmldsa). The change cleans up the public API surface oflibcrux-sha3by hiding specialized incremental functions (e.g.,x4::incremental,x2::incremental, andportable::incremental) unless one of the new features is enabled.Changes
mlkemandmldsaoptional features tocrates/algorithms/sha3/Cargo.toml.avx2::x4,neon::x2,portable::incremental) with#[cfg(any(feature = "mlkem", feature = "mldsa"))].libcrux-ml-kem,libcrux-ml-dsa,ctgrind-test) to enable these features where needed.Fixes #1532