fix: quote search queries to prevent FTS5 special-char crashes#1
Open
JessicaMulein wants to merge 1 commit into
Open
fix: quote search queries to prevent FTS5 special-char crashes#1JessicaMulein wants to merge 1 commit into
JessicaMulein wants to merge 1 commit into
Conversation
Cymbal's SQLite FTS5 index interprets hyphens, plus signs, and other special characters as query operators. When users search for terms like 'vault-store' or 'home-entry', the unquoted hyphen is parsed as a NOT operator, causing 'no such column' SQL errors. Fix: wrap all search/investigate/find_references queries in double quotes when they contain FTS5 special characters (-+*~). Quoted terms are treated as literal phrase matches by FTS5, preventing the SQL interpretation. Affects: search(), investigate(), find_references() in CymbalSubprocess.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cymbal FTS5 interprets hyphens as NOT operators causing SQL crashes. Wraps queries in quotes when they contain special chars.