refactor(server): remove Run/Option, use Start/Done/Wait/Shutdown#413
Open
wc4440222 wants to merge 1 commit into
Open
refactor(server): remove Run/Option, use Start/Done/Wait/Shutdown#413wc4440222 wants to merge 1 commit into
wc4440222 wants to merge 1 commit into
Conversation
Per hao022 feedback on ccfos#311, remove the legacy Run function and Option type from internal/server. Align huatuo-bamai with the same Start -> Done/Wait -> Shutdown pattern used by huatuo-apiserver. Changes: - handlers.Start returns (RunningServer, error) using httpServer.Start - startHandlers saves the returned server and registers Shutdown as cleanup - Daemon monitors apiServer.Done() for unexpected exits - Remove Run, run, and Option from internal/server - Remove unused backoff and syscall imports Signed-off-by: wc4440222 <[email protected]>
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Per @hao022 feedback on #311, this PR removes the legacy
Runfunction andOptiontype frominternal/server, aligninghuatuo-bamaiwith the sameStart → Done/Wait → Shutdownpattern used byhuatuo-apiserver.Changes
internal/server/server.goRun,run, andOptiontypebackoffandsyscallimportscmd/huatuo-bamai/handlers/server.goStartnow returns(RunningServer, error)instead of nothinghttpServer.Start(opts.Addr)instead ofs.Run(&Option{...})EnableRetryfrom config (no longer needed)RunningServerinterface (matching apiserver pattern)cmd/huatuo-bamai/tracing.gostartHandlerssaves the returnedRunningServertod.apiServerrunningServer.Shutdownas daemon cleanupcmd/huatuo-bamai/main.goapiServerfield toDaemonstructwaitForSignalnow monitorsapiServer.Done()for unexpected exits(os.Signal, error)to propagate serve errorsReference
This follows the pattern in
cmd/huatuo-apiserver/where:handlers.Startreturns(RunningServer, error)startHandlerssaves the server and registersShutdownas cleanupDaemon.waitForSignalmonitorsserver.Done()