fix: accept legacy Every Code config shapes#394
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
[tui].alternate_screenvalues (true->always,false->never)[tui.theme]table config by reading itsnamefield as the theme string[features].skillsas a removed no-op so dogfood config does not spam unknown-feature warningsValidation
cargo test -p codex-features skills_feature_key_is_accepted_as_removed_noop --lockedcargo test -p codex-core legacy_tui_alternate_screen --lockedcargo test -p codex-core alternate_screen_string_mode --lockedcargo test -p codex-core tui_theme_deserializes --locked./build-fast.sh~/.code; confirmed app-server used~/.code/state_5.sqliteand~/.code/logs_2.sqlite, with no freshinvalid configuration,alternate_screen/theme string parse, orunknown feature key in config: skillslogsReview
legacy-config-compat-review: no merge blockers; low notes accepted as non-blockingRelated