Add Friedland Chapter 7 Jupyter notebook - #1189
Conversation
Hi @henrydingliu and @priyam0k , I attach my work-in-progress notebook for Ch. 7. It currently contains the following:
What remains to be done (which I am continuing to work on) is the following:
I have the following questions/observations to make based on my work so far:
If you agree that this is a bug or that the issue should be looked at further, I would be happy to take the appropriate steps. I had to supress this warning for the notebook to properly display some of the code without the warning.
Essentially, the default setting in Chainladder is to round HTML-rendered output to a prespecified number of decimal places for presentational quality depending on the average magnitude of the numbers (so based on the above the ldfs automatically round to 2 decimal places when rendered as HTML (which is what I think the notebook approach is doing). There are likely good reasons for the default display format above, but it does interfere with rendering of unrounded values in some circumstances (such as in the Jupyter notebook) and required a manual override. I raising this in case the default display code above needs to be reassessed.
I will send an update in the next couple of days, but in the meantime the work continues. |
Pyright Type CompletenessView the full Project (full
Other symbols referenced but not exported by
Symbols without documentation:
Patch (exported symbols added or changed by this PR): no exported symbol type-completeness changes detected. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1189 +/- ##
=======================================
Coverage 91.14% 91.14%
=======================================
Files 91 91
Lines 5365 5365
Branches 681 681
=======================================
Hits 4890 4890
Misses 340 340
Partials 135 135
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
one general comment first. if you are still working through things, keep the PR as a draft
it's an annoyance for sure. but we also value the transparency. just leave it there for the time being
keep the code visible. as for standardization, i think having a bit of variety actually gives our repo more character, i.e. we have a vibrant group of collaborators with different coding styles. there's some stuff we can standardize after we are through all the chapters. but not a priority for the time being.
just leave the rst for now. you can change the rst title to part I and have both parts on the toc |
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit e809abb. Configure here.
|
great progress on this @salexanian! since you're actively working through exhibit iv and the assertions, feel free to convert this to a draft PR so you don't feel rushed by review notifications. tag us whenever it's ready for final review! |

Summary of Changes
This PR replaces the Chapter 7 .rst documentation with a Jupyter notebook.
Current progress:
-Migrated Exhibits I and II.
-Added Exhibit III.
-Updated the supporting data.
Remaining work includes:
-Exhibit IV.
-Assertions against Friedland.
-Formatting and notebook cleanup.
Related GitHub Issue(s)
#588
Additional Context for Reviewers
I will post a follow-up comment with several implementation observations and questions.
Checklist
uv run pytest) and documentation changes (uv run --directory docs jb build . --builder=custom --custom-builder=doctest)Note
Low Risk
Documentation navigation only; no runtime code or library API changes in this diff.
Overview
Updates the Jupyter Book table of contents so Friedland Chapter 7 is published as two sibling sections instead of a single entry.
Chapter 7 - Part I keeps
friedland/chapter_7.rstand adds an explicit TOC title. Chapter 7 - Part II is a new section pointing atfriedland/chapter_7_part_2.ipynb, which wires the second notebook into the Friedland chapter navigation alongside the existing Chapter 6, 9, and 10 materials.Reviewed by Cursor Bugbot for commit 9be61ee. Bugbot is set up for automated code reviews on this repo. Configure here.