fix: return {:ok, module} from validate_module callbacks - #41
Merged
Conversation
NimbleOptions 1.1.x requires custom validators to return
{:ok, value} instead of just :ok. The x402 plug fails to
boot with the new nimble_options because Hooks.validate_module/1,
Storage.validate_module/1, and Verifier.validate_module/1
return :ok on success.
Update all three validators to return {:ok, module} and
adjust the test expectations to match.
cardotrejos
approved these changes
Jun 21, 2026
Owner
|
@hkedia thanks for your contribution |
cardotrejos
enabled auto-merge (squash)
June 21, 2026 15:33
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
NimbleOptions 1.1.x requires custom validators to return {:ok, value} instead of just :ok. The x402 plug fails to boot with the new nimble_options because Hooks.validate_module/1, Storage.validate_module/1, and Verifier.validate_module/1 return :ok on success.
Update all three validators to return {:ok, module} and adjust the test expectations to match.