fix(TimePicker): add Storybook controls - #23005
Open
Subhom1 wants to merge 2 commits into
Open
Conversation
✅ Deploy Preview for v2-carbon-react ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for v3-carbon-web-components ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for v11-carbon-react ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for v11-carbon-web-components ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for carbon-elements ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #23005 +/- ##
==========================================
+ Coverage 89.80% 90.49% +0.69%
==========================================
Files 611 271 -340
Lines 54981 40590 -14391
Branches 7796 2230 -5566
==========================================
- Hits 49373 36731 -12642
+ Misses 5462 3841 -1621
+ Partials 146 18 -128
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #20960
Adds operative Storybook controls to every TimePicker story for both
@carbon/reactand@carbon/web-components. The default and layered stories now share the same control surface where applicable, include action logging for supported events, and use realistic example content.Changelog
New
onBlur,onChange, andonClick.changeevent.Changed
Defaultand_WithLayerstories to use the same operative controls.DefaultandWithLayerstories to use the same operative controls.childrenfrom controls because it is not a useful control for this composed story example.Removed
Testing / Reviewing
Use the repository Node version:
Run focused checks:
Build Storybook for both implementations:
Review React Storybook:
Components/TimePicker.Defaultexposes operative controls._WithLayerexposes the same TimePicker controls.Review Web Components Storybook:
Components/Time Picker.Defaultexposes operative controls.WithLayerexposes the same TimePicker controls.changeaction logs when the time picker changes.Test Screenshots
PR Checklist
As the author of this PR, before marking ready for review, confirm you:
Tested for cross-browser consistencyMore details can be found in the pull request guide