Skip to content

enh: tolerate hardcoded family-specific paths in backend tests #693

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
almeidaraul wants to merge 1 commit into
base: main
Choose a base branch
from
Open

enh: tolerate hardcoded family-specific paths in backend tests #693

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .github/copilot-instructions.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,6 +85,7 @@ When reviewing PRs, **flag any new artefact-specific logic as a blocking issue**
- New integrations with artefact-specific external APIs (Snapcraft, Launchpad, etc.)
- New family-specific frontend routes, widgets, or UI branches
- These violate the core design principle and must not be introduced in new code
- **Exception**: Hardcoded family-specific URIs/paths in backend **tests** are acceptable (e.g., test data with `/snaps/:id` or `/debs/:id` in mock responses/fixtures)

Copilot AI Apr 6, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The example placeholders /snaps/:id and /debs/:id don’t match the URL forms used in the backend tests (they typically use concrete IDs like /snaps/1 or FastAPI-style {id}). Consider updating the examples to reflect the existing pattern to avoid confusion, and (optionally) clarifying that the exception is about string literals in mocks/fixtures—not new family-specific branching logic in tests.

Suggested change
- **Exception**: Hardcoded family-specific URIs/paths in backend **tests** are acceptable (e.g., test data with `/snaps/:id` or `/debs/:id` in mock responses/fixtures)
- **Exception**: Hardcoded family-specific URI/path string literals in backend **tests** are acceptable when they are part of mock responses or fixtures (e.g., `/snaps/1` or `/debs/1`); this does **not** permit new family-specific branching logic in tests

Copilot uses AI. Check for mistakes.

2. **Resource leaks**:
- Missing `finally` blocks for state cleanup
Expand Down
Loading