Autodetect if it is possible to ssh to the openstack vm skipping proxy#94
Merged
Conversation
The idea is to bypass the proxy configuratio when it is not needed, so we don't need to duplicate the backends configuration
c308b05 to
2efd1a7
Compare
maykathm
approved these changes
Jun 10, 2026
maykathm
left a comment
Collaborator
There was a problem hiding this comment.
Looks good for our context. My only hesitation is that if I set a proxy in spread, I assume that proxy will be used. This is changing it to a "only use if you really need to" approach. I think the approach change is fine, but perhaps we should declare this behavior in the readme or somewhere
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The idea is to bypass the proxy configuratio when it is not needed, so we don't need to duplicate the backends configuration