asserts: introduce NewExternalKeypairManagerWithBackend#17197
Open
pedronis wants to merge 2 commits into
Open
Conversation
…entation rename the backend to externalCmdKeypairMgrBackend and make it standalone
now instead of just supporting external commands to implement keypair manager logic this can be done in code via backend implementations (interface ExtKeypairMgrBackend).
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #17197 +/- ##
==========================================
- Coverage 79.17% 79.17% -0.01%
==========================================
Files 1377 1379 +2
Lines 193225 193232 +7
Branches 2466 2466
==========================================
- Hits 152989 152986 -3
- Misses 31056 31063 +7
- Partials 9180 9183 +3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
Mon Jun 15 13:53:53 UTC 2026 Failures:Skipped tests from snapd-testing-skipIf you wish to have any of the below tests run in your PR, in your PR description, add 'unskip:' followed by a copy-and-pasted list (without variants) of the below tests you wish to run (unskip plus test list must be valid yaml)
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Now instead of just supporting external commands to implement keypair manager logic,
this can be done in code via backend implementations (interface ExtKeypairMgrBackend).
It might be better to review the commits separately, the first makes the ExtKeyparManager a thin wrapper around the implementation.