o/snapstate: add secondary prerequisites task#17189
Draft
andrewphelpsj wants to merge 9 commits into
Draft
Conversation
…ct retry code for install/update
This change isn't needed, but does result in much nicer graphs for snap installations/refreshes that pull in prerequisites.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #17189 +/- ##
==========================================
- Coverage 79.15% 79.13% -0.02%
==========================================
Files 1376 1385 +9
Lines 192837 193288 +451
Branches 2466 2466
==========================================
+ Hits 152640 152964 +324
- Misses 31024 31144 +120
- Partials 9173 9180 +7
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
8bad44e to
cb0a3f9
Compare
|
Thu Jun 11 21:58:03 UTC 2026 Failures:Executing:
Restoring:
Skipped tests from snapd-testing-skipIf you wish to have any of the below tests run in your PR, in your PR description, add 'unskip:' followed by a copy-and-pasted list (without variants) of the below tests you wish to run (unskip plus test list must be valid yaml)
|
Member
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This secondary
prerequisitestask acts as the synchronization point, which ensures that a snap's prerequisites are available before the snap itself is installed. This secondprerequisitestask does not trigger any installations or refreshes.This enables the earlier
prerequisitestask to trigger the installations and refreshes, which will allow seed-refresh to ensure that allprerequisiteshave been resolved prior to seed creation.Note that this first PR does not actually resolve the issue with seed-refresh. Instead, it just introduces the new
prerequisitestask as the first local modification inducing task. Since the task itself is idempotent, there shouldn't be behavioral changes.