boot/makebootable.go: allow reprovision without factory reset#17178
Open
valentindavid wants to merge 1 commit into
Open
boot/makebootable.go: allow reprovision without factory reset#17178valentindavid wants to merge 1 commit into
valentindavid wants to merge 1 commit into
Conversation
|
Thu Jun 11 18:28:35 UTC 2026 Failures:Preparing:
Executing:
Restoring:
Skipped tests from snapd-testing-skipIf you wish to have any of the below tests run in your PR, in your PR description, add 'unskip:' followed by a copy-and-pasted list (without variants) of the below tests you wish to run (unskip plus test list must be valid yaml)
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #17178 +/- ##
==========================================
+ Coverage 79.11% 79.17% +0.05%
==========================================
Files 1387 1377 -10
Lines 193301 193149 -152
Branches 2466 2466
==========================================
- Hits 152929 152924 -5
+ Misses 31177 31043 -134
+ Partials 9195 9182 -13
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
pedronis
approved these changes
Jun 10, 2026
pedronis
left a comment
pedronis
left a comment
Contributor
There was a problem hiding this comment.
thanks, couple small comments
| }) | ||
| } | ||
|
|
||
| func MakeRunnableSystemReprovision(model *asserts.Model, bootWith *BootableSet, bootAssets BootAssets, encryption *EncryptionSetup) error { |
Contributor
There was a problem hiding this comment.
this needs a d doc comment
Comment on lines
+350
to
+354
| LegacyFactoryResetKeyPath bool | ||
| Reprovision bool | ||
| SeedDir string | ||
| StateUnlocker Unlocker | ||
| UseTokens bool |
Contributor
There was a problem hiding this comment.
maybe it would be good to group the FDE/TPM options separately from the rest here
FactoryReset flag was used for 2 things: * The path to some key files is different. * Whether TPM should be reprovisioned rather than fully provisioned. With FDE reprovision, only the second one is needed. So we need to split the flag in two.
valentindavid
force-pushed
the
valentindavid/allow-reprovision-without-factory-reset
branch
from
ac7430f to
5ba1007
Compare
github-actions
Bot
added
the
Auto rerun spread
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
FactoryReset flag was used for 2 things:
With FDE reprovision, only the second one is needed. So we need to split the flag in two.