daemon, o/snapstate: implement snapstate.InstallPath in terms of refresh#17166
Open
andrewphelpsj wants to merge 2 commits into
Open
daemon, o/snapstate: implement snapstate.InstallPath in terms of refresh#17166andrewphelpsj wants to merge 2 commits into
andrewphelpsj wants to merge 2 commits into
Conversation
github-actions
Bot
added
the
Needs Documentation -auto-
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #17166 +/- ##
==========================================
- Coverage 79.12% 79.12% -0.01%
==========================================
Files 1385 1388 +3
Lines 193310 193402 +92
Branches 2466 2466
==========================================
+ Hits 152954 153020 +66
- Misses 31165 31185 +20
- Partials 9191 9197 +6
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
miguelpires
reviewed
Jun 5, 2026
|
Thu Jun 11 18:42:06 UTC 2026 Failures:Preparing:
Executing:
Restoring:
Skipped tests from snapd-testing-skipIf you wish to have any of the below tests run in your PR, in your PR description, add 'unskip:' followed by a copy-and-pasted list (without variants) of the below tests you wish to run (unskip plus test list must be valid yaml)
|
andrewphelpsj
force-pushed
the
seed-refresh-file-update
branch
2 times, most recently
from
0894708 to
5b7a043
Compare
pedronis
reviewed
Jun 11, 2026
pedronis
left a comment
pedronis
left a comment
Contributor
There was a problem hiding this comment.
behavior and symmetry question
| // Note that the state must be locked by the caller. | ||
| // The provided SideInfo can contain just a name which results in a | ||
| // local revision and sideloading, or full metadata in which case it | ||
| // the snap will appear as installed from the store. |
Contributor
There was a problem hiding this comment.
the comment here probably needs to explain the behavioral differences between this and InstallOne with PathInstallGoal or maybe the issue is that we want InstallOne with that to also do the right thing?
Member
Author
There was a problem hiding this comment.
I'll update the comment on the differences, though I'm not clear on what we want InstallOne with that to also do the right thing might mean?
Do you mean that we should consider making that trigger a seed-refresh?
This lets us use the existing seed-refresh implementation for free during single-path installation. Tests are added for this behavior.
andrewphelpsj
force-pushed
the
seed-refresh-file-update
branch
from
5b7a043 to
cf03f3b
Compare
pedronis
dismissed
miguelpires’s stale review
will need to be reviewed from scratch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This lets us use the existing seed-refresh implementation for free during single-path installation. Tests are added for this behavior.