Skip to content

daemon, o/i/apparmorprompting: implement ShutDown for InterfacesRequestsManager#17147

Draft
natibek wants to merge 2 commits into
canonical:masterfrom
natibek:generalize-shutdown-for-prompting-handler
Draft

daemon, o/i/apparmorprompting: implement ShutDown for InterfacesRequestsManager#17147
natibek wants to merge 2 commits into
canonical:masterfrom
natibek:generalize-shutdown-for-prompting-handler

Conversation

@natibek

@natibek natibek commented Jun 1, 2026

Copy link
Copy Markdown
Contributor

Implement ShutDown for the InterfacesRequestsManager to replace the existing shutdown process that uses c.d.tomb.Dying() to signal snapdShuttingDown.

Tracked with: SNAPDENG-36591

@github-actions github-actions Bot added Needs Documentation -auto- Label automatically added which indicates the change needs documentation Run only one system Only runs spread tests on one system labels Jun 1, 2026
@github-actions

github-actions Bot commented Jun 1, 2026

Copy link
Copy Markdown

Tue Jun 2 20:17:42 UTC 2026
The following results are from: https://github.com/canonical/snapd/actions/runs/26839655180

Failures:

Preparing:

  • openstack:ubuntu-24.04-64:tests/main/nvidia-files:470

Executing:

  • openstack:ubuntu-24.04-64:tests/completion/indirect:plain
  • openstack:ubuntu-24.04-64:tests/main/refresh-delta

Restoring:

  • openstack:ubuntu-24.04-64:tests/completion/indirect:plain
  • openstack:ubuntu-24.04-64:tests/completion/
  • openstack:ubuntu-24.04-64:
  • openstack:ubuntu-24.04-64:tests/main/refresh-delta
  • openstack:ubuntu-24.04-64:tests/main/
  • openstack:ubuntu-24.04-64:

Skipped tests from snapd-testing-skip

If you wish to have any of the below tests run in your PR, in your PR description, add 'unskip:' followed by a copy-and-pasted list (without variants) of the below tests you wish to run (unskip plus test list must be valid yaml)

  • openstack:ubuntu-24.04-64:tests/main/i18n
  • openstack:ubuntu-24.04-64:tests/main/snapctl-no-wait

@codecov

codecov Bot commented Jun 2, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 75.00000% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 79.07%. Comparing base (bb94da2) to head (4bc5889).
⚠️ Report is 13 commits behind head on master.

Files with missing lines Patch % Lines
overlord/ifacestate/apparmorprompting/prompting.go 72.72% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master   #17147      +/-   ##
==========================================
+ Coverage   79.00%   79.07%   +0.07%     
==========================================
  Files        1379     1380       +1     
  Lines      192453   192506      +53     
  Branches     2464     2466       +2     
==========================================
+ Hits       152043   152224     +181     
+ Misses      31242    31120     -122     
+ Partials     9168     9162       -6     
Flag Coverage Δ
unittests 79.07% <75.00%> (+0.07%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Needs Documentation -auto- Label automatically added which indicates the change needs documentation Run only one system Only runs spread tests on one system

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant