openapi: fix assertion to new-model in /v2/model#368
Closed
BAMF0 wants to merge 1 commit into
Closed
Conversation
Contributor
|
Thank you for the fix Simon! |
Contributor
|
Note: The openapi bundled with snap-docs is an old version to be displayed when the latest implementation does not build. I will make sure the changes are mirrored there if they haven't been already committed. The up-to-date documentation is in the snapd repo under |
Contributor
|
This is now being tracked by: canonical/snapd#17199 |
Contributor
|
Closing, need to update bundled openapi spec in snap-docs repo at some point. |
Author
|
Awesome! Mirroring it from the snapd repo is more reasonable than manual edits. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change the
/v2/modelPOST example JSON to use thenew-modelfield instead ofassertion, as this is what is expected by snapd for API calls.Reference: https://github.com/canonical/snapd/blob/49b363c11dc2c79213aa466d9898dc3bd779287f/daemon/api_model.go#L67
Fixes #367