feat: add version subcommand aliased to the --version flag#197
Open
tonyandrewmeyer wants to merge 2 commits into
Open
feat: add version subcommand aliased to the --version flag#197tonyandrewmeyer wants to merge 2 commits into
version subcommand aliased to the --version flag#197tonyandrewmeyer wants to merge 2 commits into
Conversation
`concierge --version` works but `concierge version` fails with `unknown command "version"`, which is a confusing failure for anyone (human or agent) who guesses the subcommand form. Add a `version` Cobra subcommand on the root command that renders the same version template Cobra uses for the `--version` flag, against the root command. The two paths now produce identical output and share the same `version`/`commit` strings, so they cannot drift. A test in `cmd/` exercises both paths through the root command and asserts the outputs are byte-for-byte equal.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
concierge --versionworks butconcierge versionfails withunknown command "version", which is a confusing failure for anyone (human or agent) who guesses the subcommand form. Our CLI standards and other tools seem to expect that aversioncommand is present.Add a
versionCobra subcommand on the root command that renders the same version template Cobra uses for the--versionflag, against the root command. The two paths now produce identical output and share the sameversion/commitstrings, so they cannot drift.A test in
cmd/exercises both paths through the root command and asserts the outputs are byte-for-byte equal.