feat: add local file and dir uploads configuration#29
Open
a-dubs wants to merge 2 commits intocanonical:mainfrom
Open
feat: add local file and dir uploads configuration#29a-dubs wants to merge 2 commits intocanonical:mainfrom
a-dubs wants to merge 2 commits intocanonical:mainfrom
Conversation
a-dubs
force-pushed
the
add-local-upload-config
branch
from
46f41a3 to
37e27f9
Compare
rpocase
requested changes
Jan 28, 2025
Collaborator
rpocase
left a comment
rpocase
left a comment
There was a problem hiding this comment.
- can we add unit tests
- are there exceptional cases we should consider as part of this implementation? what errors could we catch to better help the user?
toabctl
requested changes
Jan 29, 2025
Collaborator
toabctl
left a comment
toabctl
left a comment
There was a problem hiding this comment.
- needs unittests
- needs functional tests
- needs documentation
Author
|
@toabctl I know I know I marked this as WIP, I just wanted to know if this is something you think is worth adding before proceeding to put time into finalizing this work. |
Collaborator
toabctl
reviewed
Jan 29, 2025
Author
I was unaware of the to-do list!! Thank you for pointing that out. Will be sure to mark this item as done as part of this PR. |
a-dubs
force-pushed
the
add-local-upload-config
branch
3 times, most recently
from
173232e to
e0fb364
Compare
Author
a-dubs
force-pushed
the
add-local-upload-config
branch
from
e0fb364 to
bb05937
Compare
toabctl
requested changes
Mar 13, 2025
rpocase
previously approved these changes
Mar 13, 2025
Collaborator
rpocase
left a comment
rpocase
left a comment
There was a problem hiding this comment.
lgtm pending tom's suggestion and my nits.
a-dubs
force-pushed
the
add-local-upload-config
branch
from
b8271d7 to
b6289d6
Compare
Since linting and testing paths are not specified by default in tox.ini, they would find various untracked files in my working directory and cause the tests to fail. This change sets the posargs to a more reasonable default, and adds a lint-fix environment to tox.ini which will run black and have it auto format the code.
a-dubs
force-pushed
the
add-local-upload-config
branch
from
b6289d6 to
9877222
Compare
Author
a-dubs
force-pushed
the
add-local-upload-config
branch
from
9877222 to
f4009bf
Compare
This change updates the ConfigFile configuration to allow for specifying a source path that can be either a directory or file and copying this to the chroot at the destination path. The 'source' field is mutually exclusive with the 'content' field for the ConfigFile type.
a-dubs
force-pushed
the
add-local-upload-config
branch
from
f4009bf to
83bd719
Compare
toabctl
requested changes
Apr 2, 2025
| import yaml | ||
|
|
||
| from chimg.common import run_command | ||
| from chimg.config import ConfigFile |
Collaborator
There was a problem hiding this comment.
don't import config. This should go through Context. Context should be the only direct user of Config. so use self.ctx.conf
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.