Fix two walkthroughs for current CanlabCore API#3
Open
torwager wants to merge 1 commit into
Open
Conversation
Surfaced by the hardened CanlabCore walkthrough smoke tests: - canlab_help_3_voxelwise_t_test_walkthrough: write() no longer silently overwrites an existing file. The script wrote example_t_image.nii then re-wrote the same path with 'thresh', which now errors. Pass 'overwrite' on both writes so the section is also idempotent on re-run. - canlab_help_4b_3D_visualization: per-image metadata for the kragel18 dataset now lives in .metadata_table, not the (now-empty) .dat_descrip, so metadata(1:5,:) / metadata.Domain failed. Read from .metadata_table. Co-Authored-By: Claude Opus 4.8 (1M context) <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Two CANlab walkthroughs no longer ran end-to-end against the current CanlabCore API. Both were surfaced by the new hardened walkthrough smoke tests in canlab/CanlabCore#79.
canlab_help_3_voxelwise_t_test_walkthrough—write()no longer silently overwrites an existing file. The script wroteexample_t_image.nii, then re-wrote the same path with'thresh', which now errors with "File already exists. Use 'overwrite' option to force overwrite." Pass'overwrite'on both writes (also makes the section idempotent on re-run).canlab_help_4b_3D_visualization— per-image metadata for the kragel18 dataset now lives in.metadata_table(270×6, with theDomaincolumn), not the now-empty.dat_descrip, sometadata(1:5,:)/metadata.Domainthrew an out-of-bounds error. Read from.metadata_table.Verification
Both walkthroughs run clean through the CanlabCore harness (10/10 walkthrough tests pass) after these changes + refreshing the bundled snapshots in #79.
🤖 Generated with Claude Code