fix: support accessibilityLabelledBy arrays#1907
Open
sjh9714 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes accessible name matching when
accessibilityLabelledByis an array.React Native types allow
accessibilityLabelledByto bestring | string[], butthe previous lookup compared
nativeIDdirectly with the prop value. That madegetByRole('button', { name })miss elements labelled by an array value.This PR keeps the existing string behavior and normalizes the label id prop to
an array before matching label elements.
Fixes #1839
Test plan
yarn test src/queries/__tests__/role.test.tsx -t accessibilityLabelledByyarn test src/queries/__tests__/role.test.tsxyarn typecheckyarn lintyarn testyarn prettiergit diff --check