Skip to content

Commit returns 'None' on failed config with commit_error_dialog_dict set #25

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
nights99 wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

Commit returns 'None' on failed config with commit_error_dialog_dict set #25

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions netmiko/cisco/cisco_xr.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -200,6 +200,8 @@ def commit(self, confirm=False, confirm_delay=None, comment='', label='',
output += self.send_command_timing(marker_value, strip_prompt=False, strip_command=False,
delay_factor=delay_factor)
return output
else:
raise err
elif alt_error_marker in output:
# Other commits occurred, don't proceed with commit
output += self.send_command_timing("no", strip_prompt=False, strip_command=False,
Expand Down