UI: unsuccessful push should scream "error!" instead of failing silently

[bryango]

Version: @v12

I forget to configure the secret key for one of my repo's action (my bad), but cachix push simply fails silently without warning. One has to dig into the log to find that:

Post job cleanup.
Cachix: push
  Pushing is disabled as signingKey nor authToken are set (or are empty?) in your YAML file.

I believe that the push action should scream "error!" and fail if it's unsuccessful. It's much easier to debug!

[domenkozar]

It's tricky, because most of the time this is intended, for example in pull requests where the user doesn't have access to the secrets.

We could however check if user has write access and make it an error/warning then.

[bryango]

It's tricky, because most of the time this is intended, for example in pull requests where the user doesn't have access to the secrets.

I see, that's a reasonable use case.

We could however check if user has write access and make it an error/warning then.

That's a good idea! Or maybe, one can indicate a cachix push failure without failing the whole jobset? I'm not sure whether this is possible with GitHub actions.