Skip to content

refactor: Fix more easy mypy issues.#199

Merged
bvanelli merged 6 commits into
mainfrom
mypy/other-cases
May 28, 2026
Merged

refactor: Fix more easy mypy issues.#199
bvanelli merged 6 commits into
mainfrom
mypy/other-cases

Conversation

@bvanelli

@bvanelli bvanelli commented Apr 23, 2026

Copy link
Copy Markdown
Owner
  • Numerous fixes to the fit the mypy type checker
  • Add mypy workflow check on Github actions
  • Rules file still remains ugly with a lot of type-ignores since it was very hard to get the types right without a bigger refactor. They should be tackled in a follow up.

Closes #190

@codecov

codecov Bot commented Apr 23, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 96.69421% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 97.54%. Comparing base (8bf97c6) to head (a0b67dc).
⚠️ Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
actual/rules.py 96.80% 3 Missing ⚠️
actual/__init__.py 75.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #199      +/-   ##
==========================================
- Coverage   97.62%   97.54%   -0.08%     
==========================================
  Files          21       21              
  Lines        3238     3257      +19     
==========================================
+ Hits         3161     3177      +16     
- Misses         77       80       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@bvanelli bvanelli marked this pull request as ready for review May 28, 2026 18:54
bvanelli and others added 3 commits May 28, 2026 20:55
The v8 major tag is not published by astral-sh/setup-uv, causing
workflow runs to fail with "unable to find version v8".

Co-Authored-By: Claude Opus 4.7 (1M context) <[email protected]>
@bvanelli bvanelli merged commit ecfc878 into main May 28, 2026
10 checks passed
@bvanelli bvanelli deleted the mypy/other-cases branch May 28, 2026 19:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Introduce type checking to repository

1 participant