fix: correct typo DisableSystemBuilpacks to DisableSystemBuildpacks#2634
Open
saiashok0981 wants to merge 1 commit into
Open
fix: correct typo DisableSystemBuilpacks to DisableSystemBuildpacks#2634saiashok0981 wants to merge 1 commit into
saiashok0981 wants to merge 1 commit into
Conversation
The BuildFlags struct field 'DisableSystemBuilpacks' has been misspelled since the feature was introduced. The public CLI flag '--disable-system-buildpacks' was always correct, but the Go struct identifier was missing the letter 'd', making it inconsistent and confusing for contributors reading the source code. This commit: - Renames BuildFlags.DisableSystemBuilpacks -> BuildFlags.DisableSystemBuildpacks - Updates the flag binding in buildCommandFlags() to use the corrected field - Updates the BuildOptions struct literal to reference the corrected field No behavioral change; purely a naming correction. The generated CLI flag name remains '--disable-system-buildpacks' as before. Signed-off-by: [email protected]
github-actions
Bot
added
the
type/enhancement
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The BuildFlags struct field 'DisableSystemBuilpacks' has been misspelled since the feature was introduced. The public CLI flag '--disable-system-buildpacks' was always correct, but the Go struct identifier was missing the letter 'd', making it inconsistent and confusing for contributors reading the source code.
This commit:
No behavioral change; purely a naming correction. The generated CLI flag name remains '--disable-system-buildpacks' as before.
Signed-off-by: [email protected]
Summary
Output
Before
After
Documentation
Related
Resolves #___