Pin Beta Release tag to build commit#2604
Open
runesoerensen wants to merge 1 commit into
Open
Conversation
github-actions
Bot
added
the
type/chore
The `Create Beta Release` step in `build.yml` doesn't set `target_commitish`, so `softprops/action-gh-release` defaults the tag to `main`. Because `release-merge.yml` runs in parallel and pushes the release branch into `main`, by the time the Beta Release step runs, `main` may include commits that aren't in the binary — causing the published artifacts and the source at the tag to silently disagree (as happened in v0.40.5; see buildpacks#2603). Set `target_commitish: ${{ github.sha }}` to pin the tag to the release-branch commit the binaries were built from. Mirrors what the `Create Pre-Release` step already does. Fixes buildpacks#2603 Signed-off-by: Rune Soerensen <[email protected]>
runesoerensen
force-pushed
the
fix/beta-release-target-commitish
branch
from
8eb1774 to
40acdf8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
Create Beta Releasestep inbuild.ymldoesn't settarget_commitish, sosoftprops/action-gh-releasedefaults the tag tomain. Becauserelease-merge.ymlruns in parallel and pushes the release branch intomain, by the time the Beta Release step runs,mainmay include commits that aren't in the binary — causing the published artifacts and the source at the tag to silently disagree (as happened in v0.40.5).Set
target_commitish: ${{ github.sha }}to pin the tag to the release-branch commit the binaries were built from. Mirrors what theCreate Pre-Releasestep already does.Fixes #2603