Display ReportResultStage slots for each worker#3
Merged
werkt merged 1 commit intoOct 6, 2025
Conversation
JaredNeil
commented
Apr 25, 2025
Comment on lines
+550
to
+575
| var format_string string | ||
| if slots < 10 { | ||
| format_string = "# %d/%d #" | ||
| } else if slots < 100 { | ||
| format_string = "# %2d/%2d #" | ||
| } else { | ||
| format_string = "# %3d/%3d #" | ||
| } |
Author
There was a problem hiding this comment.
There is probably a better way to do this, but I'm not super familiar with Go.
jasonschroeder-sfdc
approved these changes
May 21, 2025
jasonschroeder-sfdc
added a commit
to jasonschroeder-sfdc/bf-client
that referenced
this pull request
May 22, 2025
JaredNeil
force-pushed
the
jaredneil/display-report-stage
branch
from
2643721 to
f995ebb
Compare
JaredNeil
force-pushed
the
jaredneil/display-report-stage
branch
from
f995ebb to
577c8af
Compare
Author
|
@jasonschroeder-sfdc, could this be merged now? |
Contributor
|
That's up to @werkt , I have no powers here 😂 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We ran into an issue where the report stage was really slow (CAS workers were overwhelmed) and it wasn't obvious that the execution slots were all full because they were stalled waiting on the single report stage. This adds a column for the report stage. Unfortunately having three columns means there will be a gap after the execution stage unless it's full. Happy to rework the formatting if you think there's a better way to lay this out.