Skip to content

fix(core): context engineering post-review fixes (#229, #230, #231, #232) - #235

Merged
bug-ops merged 2 commits into
mainfrom
feat/234/context-post-review
Feb 14, 2026
Merged

fix(core): context engineering post-review fixes (#229, #230, #231, #232)#235
bug-ops merged 2 commits into
mainfrom
feat/234/context-post-review

Conversation

@bug-ops

@bug-ops bug-ops commented Feb 14, 2026

Copy link
Copy Markdown
Owner

Summary

Post-implementation review of v0.9.4 context engineering identified 5 gaps. This PR fixes the top 4 (P0-P2):

Gap 5 (#233, file watcher for code index) deferred to follow-up PR.

Test plan

  • Existing test suite passes (1276 tests, 0 failures)
  • New test: remember_with_parts_saves_parts_json — verifies parts JSON persisted to SQLite
  • Updated test: test_prune_frees_tokens — asserts body is empty after prune
  • New test: test_repo_map_cache_hit — validates cache field populated and stable
  • New test: test_cross_session_score_threshold_filters — verifies score filtering

Closes #229, closes #230, closes #231, closes #232

…, filter cross-session scores

- Persist message parts to SQLite via remember_with_parts() (#229)
- Clear tool output body after pruning to reclaim memory (#230)
- Cache repo map with configurable TTL to avoid per-message regeneration (#231)
- Filter cross-session search results by score threshold (#232)
@github-actions github-actions Bot added bug Something isn't working memory zeph-memory crate (SQLite) rust Rust code changes core zeph-core crate dependencies Dependency updates config Configuration file changes size/L Large PR (201-500 lines) and removed bug Something isn't working labels Feb 14, 2026
@codecov-commenter

codecov-commenter commented Feb 14, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 64.86486% with 52 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
crates/zeph-core/src/agent.rs 64.13% 33 Missing ⚠️
crates/zeph-memory/src/semantic.rs 61.70% 18 Missing ⚠️
src/main.rs 0.00% 1 Missing ⚠️

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #235      +/-   ##
==========================================
- Coverage   81.04%   80.96%   -0.08%     
==========================================
  Files          78       78              
  Lines       22999    23137     +138     
==========================================
+ Hits        18640    18734      +94     
- Misses       4359     4403      +44     
Files with missing lines Coverage Δ
crates/zeph-core/src/config.rs 98.92% <100.00%> (+<0.01%) ⬆️
src/main.rs 70.85% <0.00%> (-0.06%) ⬇️
crates/zeph-memory/src/semantic.rs 78.95% <61.70%> (-0.97%) ⬇️
crates/zeph-core/src/agent.rs 69.17% <64.13%> (+<0.01%) ⬆️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

- Add cross_session_score_threshold and repo_map_ttl_secs to config docs
- Document parts persistence and body clearing in pruning section
- Update budget allocation ratios in README
- Add changelog entries for #229, #230, #231, #232
@github-actions github-actions Bot added bug Something isn't working documentation Improvements or additions to documentation and removed bug Something isn't working labels Feb 14, 2026
@bug-ops
bug-ops enabled auto-merge (squash) February 14, 2026 09:08
@github-actions github-actions Bot added the bug Something isn't working label Feb 14, 2026
@bug-ops
bug-ops merged commit 13282ad into main Feb 14, 2026
23 checks passed
@bug-ops
bug-ops deleted the feat/234/context-post-review branch February 14, 2026 09:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working config Configuration file changes core zeph-core crate dependencies Dependency updates documentation Improvements or additions to documentation memory zeph-memory crate (SQLite) rust Rust code changes size/L Large PR (201-500 lines)

Projects

None yet

2 participants