[DASH-2149] [templates] initialize javascript templates on production branch#100
Open
syd-shields wants to merge 4 commits into
Conversation
…#75) * init * add a build step that turns new ts templates into js in CI * add file filter to build script * add built js templates * add exclude flag * add comments to explain build filters * add build step to run on dev branch in CI * regen templats on each pr merge * include all readme, package json and env examples in build * get paths to build js files first so that the entire repo isn't deleted and rewritten with new build * remove built js files * only build js files to production branch * remove build javascript workflow * before recursing, skip directories whose basename is in DEFAULT_EXCLUDED_DIRS * before recursing, skip directories whose basename is in DEFAULT_EXCLUDED_DIRS * if there are zero playground compatible templates, do not call build-javascript.mjs * add test-production branch support * build js templates * remove built js files * add pkg.type = module to adaptPackageJsonForJavaScript so it's unconditionally set for all generated JS templates * consolidate workflows to one plauground.yml file to remove need to make updates to it twice * write contents to test-production and production branches * use hardcoded branch names instead of unused var * add --no-verify flag to build * add stripLeadingTscBuildCommand to handle when multiple commands exist alongside tsc * add parseBuildOptions to parse CLI flags at once instead of in multiple places to prevent drift
…down/json formats (#98)
Contributor
Author
|
This change is part of the following stack: Change managed by git-spice. |
syd-shields
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds CI job that builds javascript templates to the production branch.
Note
Low Risk
Single default URL change in a fetch script; overrides via TEMPLATES_API_URL remain, with no auth or data-model changes.
Overview
Updates the default templates list URL used by
fetch-playground-typescript-dirs.mjswhen neither an explicitapiUrlnorTEMPLATES_API_URLis set: fromhttps://www.browserbase.com/website-api/templatestohttps://www.browserbase.com/api/templates.That endpoint feeds playground TypeScript template discovery (including init flows on production). Callers can still override via env or argument.
Reviewed by Cursor Bugbot for commit 6f78172. Bugbot is set up for automated code reviews on this repo. Configure here.