Skip to content

fix: run on Node 20 via dynamic import (+ tests, CI, docs)#14

Open
karaposu wants to merge 1 commit into
brightdata:devfrom
karaposu:node_20_related_error
Open

fix: run on Node 20 via dynamic import (+ tests, CI, docs)#14
karaposu wants to merge 1 commit into
brightdata:devfrom
karaposu:node_20_related_error

Conversation

@karaposu

Copy link
Copy Markdown
  • Node ESM crash: the ESM-only @inquirer/prompts (init.ts, add-mcp.ts) was statically imported and compiled to require(), throwing ERR_REQUIRE_ESM on Node < 22.12; load it lazily via dynamic import (utils/load-prompts.ts) and add a floor-20 guard (utils/node-version.ts)
  • tests: fix stale scrape/add-mcp assertions; skip 6 drifted browser/daemon/discover specs (mock-drift, not product bugs)
  • ci: add type-check + test workflow on push/PR (release.yml never ran tests)
  • docs: add CONTRIBUTING.md
  • bump version to 0.3.2

- Node ESM crash: the ESM-only @inquirer/prompts (init.ts, add-mcp.ts) was
  statically imported and compiled to require(), throwing ERR_REQUIRE_ESM on
  Node < 22.12; load it lazily via dynamic import (utils/load-prompts.ts) and
  add a floor-20 guard (utils/node-version.ts)
- tests: fix stale scrape/add-mcp assertions; skip 6 drifted
  browser/daemon/discover specs (mock-drift, not product bugs)
- ci: add type-check + test workflow on push/PR (release.yml never ran tests)
- docs: add CONTRIBUTING.md
- bump version to 0.3.2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant