Skip to content

docs: reboot README and fix P0 shell integration bugs#1

Merged
brianrobt merged 1 commit into
masterfrom
cursor/readme-reboot-issue-triage-d181
Jul 12, 2026
Merged

docs: reboot README and fix P0 shell integration bugs#1
brianrobt merged 1 commit into
masterfrom
cursor/readme-reboot-issue-triage-d181

Conversation

@brianrobt

@brianrobt brianrobt commented Jul 12, 2026

Copy link
Copy Markdown
Owner

Summary

Reboots gvm2 documentation and lands the first batch of fixes triaged from the unmaintained moovweb/gvm backlog.

README changes

  • Adds a prominent under active development / not production ready disclaimer
  • Explains why the project was renamed to gvm2 and detached from the upstream fork network
  • Credits original authors and links to upstream maintenance discussion (#536)
  • Adds an issue triage table grouping ~200 upstream issues into P0–P3 priorities
  • Updates install instructions to point at brianrobt/gvm2

Bug fixes (P0 — shell integration)

Upstream issue Fix
#527 Export resolved tool paths (HEXDUMP_PATH, etc.) so agent/non-login shells keep working
#528, #539 Handle aliased cd (oh-my-bash) and use "$@" to preserve argument boundaries
#515 Quote PATH segments in munge_path so directories with spaces don't break commands like code
#531 Quote paths in find_local_pkgset

Other

  • Default installer clone URL now targets brianrobt/gvm2

Next up (not in this PR)

  • P1: bootstrap without existing Go (#530), go.mod install conflicts (#525)
  • P2/P3: UX improvements, download progress, go.mod auto-detect
Open in Web Open in Cursor 

Summary by CodeRabbit

  • New Features

    • Updated installation instructions and installer defaults to use the gvm2 project.
    • Added project status, reboot background, and issue triage guidance to the documentation.
  • Bug Fixes

    • Improved directory navigation and local package-set detection.
    • Preserved PATH entries and command arguments more reliably.
    • Ensured resolved tool paths remain available across shells.

- Explain gvm2 rename, upstream maintenance status, and development disclaimer
- Add issue triage table mapping moovweb/gvm backlog to gvm2 priorities
- Point installer at brianrobt/gvm2
- Export resolved tool paths for agent/non-login shells (#527)
- Fix cd when aliased by oh-my-bash and preserve argument boundaries (#528, #539)
- Quote PATH segments containing spaces (#515)
- Quote paths in find_local_pkgset (#531)

Co-authored-by: Brian Thompson <[email protected]>
@coderabbitai

coderabbitai Bot commented Jul 12, 2026

Copy link
Copy Markdown

Review Change Stack

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: afc61b31-b29e-4927-a47e-d93c0469e327

📥 Commits

Reviewing files that changed from the base of the PR and between dd65253 and d1f9783.

📒 Files selected for processing (6)
  • README.md
  • binscripts/gvm-installer
  • scripts/env/cd
  • scripts/function/find_local_pkgset
  • scripts/function/munge_path
  • scripts/function/tools

📝 Walkthrough

Walkthrough

The PR introduces gvm2 documentation and installer references, then hardens shell argument quoting, directory discovery, PATH reconstruction, and tool-path exports.

Changes

Repository transition

Layer / File(s) Summary
Repository documentation and installer defaults
README.md, binscripts/gvm-installer
README content and installer URLs now identify brianrobt/gvm2, with development status and issue triage information added.

Shell robustness

Layer / File(s) Summary
Directory navigation safety
scripts/env/cd, scripts/function/find_local_pkgset
Directory arguments and paths are quoted while preserving parent traversal and working-directory restoration.
Path and tool environment preservation
scripts/function/munge_path, scripts/function/tools
PATH assembly preserves individual entries, and resolved tool paths are exported to child shells.

Estimated code review effort: 2 (Simple) | ~10 minutes

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch cursor/readme-reboot-issue-triage-d181

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@brianrobt
brianrobt marked this pull request as ready for review July 12, 2026 16:44
@brianrobt
brianrobt merged commit 5f8209d into master Jul 12, 2026
1 check passed
@brianrobt
brianrobt deleted the cursor/readme-reboot-issue-triage-d181 branch July 12, 2026 17:01
brianrobt added a commit that referenced this pull request Jul 13, 2026
- Explain gvm2 rename, upstream maintenance status, and development disclaimer
- Add issue triage table mapping moovweb/gvm backlog to gvm2 priorities
- Point installer at brianrobt/gvm2
- Export resolved tool paths for agent/non-login shells (#527)
- Fix cd when aliased by oh-my-bash and preserve argument boundaries (#528, #539)
- Quote PATH segments containing spaces (#515)
- Quote paths in find_local_pkgset (#531)

Co-authored-by: Cursor Agent <[email protected]>
Co-authored-by: Brian Thompson <[email protected]>
brianrobt added a commit that referenced this pull request Jul 13, 2026
- Explain gvm2 rename, upstream maintenance status, and development disclaimer
- Add issue triage table mapping moovweb/gvm backlog to gvm2 priorities
- Point installer at brianrobt/gvm2
- Export resolved tool paths for agent/non-login shells (#527)
- Fix cd when aliased by oh-my-bash and preserve argument boundaries (#528, #539)
- Quote PATH segments containing spaces (#515)
- Quote paths in find_local_pkgset (#531)

Co-authored-by: Cursor Agent <[email protected]>
Co-authored-by: Brian Thompson <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants