docs: reboot README and fix P0 shell integration bugs#1
Merged
Conversation
- Explain gvm2 rename, upstream maintenance status, and development disclaimer - Add issue triage table mapping moovweb/gvm backlog to gvm2 priorities - Point installer at brianrobt/gvm2 - Export resolved tool paths for agent/non-login shells (#527) - Fix cd when aliased by oh-my-bash and preserve argument boundaries (#528, #539) - Quote PATH segments containing spaces (#515) - Quote paths in find_local_pkgset (#531) Co-authored-by: Brian Thompson <[email protected]>
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (6)
📝 WalkthroughWalkthroughThe PR introduces gvm2 documentation and installer references, then hardens shell argument quoting, directory discovery, PATH reconstruction, and tool-path exports. ChangesRepository transition
Shell robustness
Estimated code review effort: 2 (Simple) | ~10 minutes ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
brianrobt
marked this pull request as ready for review
July 12, 2026 16:44
brianrobt
added a commit
that referenced
this pull request
Jul 13, 2026
- Explain gvm2 rename, upstream maintenance status, and development disclaimer - Add issue triage table mapping moovweb/gvm backlog to gvm2 priorities - Point installer at brianrobt/gvm2 - Export resolved tool paths for agent/non-login shells (#527) - Fix cd when aliased by oh-my-bash and preserve argument boundaries (#528, #539) - Quote PATH segments containing spaces (#515) - Quote paths in find_local_pkgset (#531) Co-authored-by: Cursor Agent <[email protected]> Co-authored-by: Brian Thompson <[email protected]>
brianrobt
added a commit
that referenced
this pull request
Jul 13, 2026
- Explain gvm2 rename, upstream maintenance status, and development disclaimer - Add issue triage table mapping moovweb/gvm backlog to gvm2 priorities - Point installer at brianrobt/gvm2 - Export resolved tool paths for agent/non-login shells (#527) - Fix cd when aliased by oh-my-bash and preserve argument boundaries (#528, #539) - Quote PATH segments containing spaces (#515) - Quote paths in find_local_pkgset (#531) Co-authored-by: Cursor Agent <[email protected]> Co-authored-by: Brian Thompson <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Reboots gvm2 documentation and lands the first batch of fixes triaged from the unmaintained moovweb/gvm backlog.
README changes
brianrobt/gvm2Bug fixes (P0 — shell integration)
HEXDUMP_PATH, etc.) so agent/non-login shells keep workingcd(oh-my-bash) and use"$@"to preserve argument boundariesmunge_pathso directories with spaces don't break commands likecodefind_local_pkgsetOther
brianrobt/gvm2Next up (not in this PR)
go.modinstall conflicts (#525)go.modauto-detectSummary by CodeRabbit
New Features
Bug Fixes