Skip to content

Handle incorrect sync markers in count tool gracefully #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
brandtg merged 1 commit into from
Feb 16, 2026
Merged

Handle incorrect sync markers in count tool gracefully #5

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion avrokit/tools/count.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,10 +47,19 @@ def fast_count_records(self, reader: avro.datafile.DataFileReader) -> int:
# Check sync marker
marker = reader.reader.read(16)
if marker != sync_marker:
raise avro.errors.AvroException("Sync marker does not match")
raise avro.errors.AvroException(
f"Sync marker does not match (after {total} records)"
)
except EOFError:
break # End of file reached
except avro.errors.AvroException as e:
if "Sync marker does not match" in str(e):
self.logger.warning(
"File may still be open for writing (sync mismatch after %d records). "
"Counting records up to last valid sync marker.",
total,
)
break
if "Read 0 bytes, expected 1 bytes" in str(e):
break # Normal end of file for Avro
self.logger.error(f"Avro error while reading block: {e}")
Expand Down