feat(getopt): add option to permit partial name matches for long flags#32
Merged
Conversation
This revision introduces a new field PosixFlagSet.RelaxedParsing which relaxes the parser to permit partial name matches for long flags. For example, when enabled, '--al' would match the flag '--algorithm', assuming no other flag names have the prefix 'al'. An associated ExecuteOption was added to enable this functionality. By default, relaxed parsing is disabled. Improved test coverage of PosixFlagSet. This revision also fixes a few bugs in package getopt. When a new flag set is created with NewPosixFlagSet, the wrong usage renderer was being called when flag parsing fails. Additionally, long-format flags were incorrectly matching short flags (e.g. '--a' accepted for flag 'a', but should not match). These bugs have been corrected and tests have been added.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This revision introduces a new field PosixFlagSet.RelaxedParsing which relaxes the parser to permit partial name matches for long flags. For example, when enabled, '--al' would match the flag '--algorithm', assuming no other flag names have the prefix 'al'.
An associated ExecuteOption was added to enable this functionality. By default, relaxed parsing is disabled.
Improved test coverage of PosixFlagSet.
This revision also fixes a few bugs in package getopt. When a new flag set is created with NewPosixFlagSet, the wrong usage renderer was being called when flag parsing fails. Additionally, long-format flags were incorrectly matching short flags (e.g. '--a' accepted for flag 'a', but should not match). These bugs have been corrected and tests have been added.