Add CEL-compliant pod security and storage settings#83
Open
JPurcell-Braintrust wants to merge 7 commits into
Open
Add CEL-compliant pod security and storage settings#83JPurcell-Braintrust wants to merge 7 commits into
JPurcell-Braintrust wants to merge 7 commits into
Conversation
Contributor
|
Overall this looks good to me. My only asks are around runtime validation rather than the Helm config itself
|
Alexey Soldatchenko (soldatchenko)
requested changes
May 12, 2026
Contributor
|
Please make sure that the PR title is descriptive, and the comments make it easy for a customer/consumer of this chart to understand what changes are being made. A few examples:
It will forever be immortalized in the public commit history and release notes. |
Alexey Soldatchenko (soldatchenko)
previously approved these changes
May 15, 2026
Contributor
Alexey Soldatchenko (soldatchenko)
left a comment
There was a problem hiding this comment.
This looks good to me now, thanks for addressing all the comments!
Note
- This does include the EKS quarantine example, make sure you truly want it in this commit and eventual release
Contributor
|
Also the Helm unit test CI is failing during
|
Alexey Soldatchenko (soldatchenko)
approved these changes
May 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding in the previous security enhancements to satisfy CEL based policies, previously based on 1.1.32 to the latest helm updates. The security enhancements were:
An example/google-autopilot-cel/ has been created to help the known customers currently needing these CEL enhancements in their production environment.