feat(deps): remove taffydb#38
Merged
Merged
Conversation
RickeySerna
reviewed
Jun 24, 2026
|
|
||
| /** | ||
| technically taffyDB object, but we use `@jsdoc/salty` to pull into database form | ||
| @param {TAFFY} taffyData See <http://taffydb.com/>. |
There was a problem hiding this comment.
Don't love taffyDB still being mentioned here since we're removing it, I think this could lead to confusion in the future. Any way this can be changed?
Contributor
Author
There was a problem hiding this comment.
the thing is the mini-module has very little documentation, i'm not sure what the shape of the data looks like. afaik it's taffyData, or it has the shape of taffyData, so i left the comment there
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of changes
TAFFYDB IS DEAD!
big CVN vuln in taffydb means we should not use it with our jsdocs! thankfully, @hegemonic built out a smaller module,
@jsdoc/saltythat does that for us!tested by running our jsdoc generation in our parent internal repo against the new publish workflow powered by taffydb, and ensuring docs were able to be generated!
Checklist
Authors
Reviewers
@braintree/team-sdk-js