Rohan changes#6
Conversation
| user: 1000 | ||
| memory: 10mb | ||
| cpu: 0.25 | ||
| args: |
There was a problem hiding this comment.
@thisrohangupta How do we want to take care of downloading of artifacts and feeding into this serverless.yaml ?
Right now , its done inside serverless package step by us before executing serverless package command , but that's not a good design here. Each plugin should have well defined responsibilities and downloading of artifacts should not be the responsibility of serverless package plugin. Customers could always script the downloading of artifacts , and then scripting the part of putting that artifact inside serverless.yml. But the question is do we want customers to script it ? Should we have a seperate plugin for handling that ? I am not sure if this is urgent , but we should think about handling artifacts in our services via an independent plugin
There was a problem hiding this comment.
We use custom expressions inside serverless manifest to feed artifact like "<+artifact.image>" and "<+artifact.path>". If we have an independent plugin for downloading artifacts, we could generalize some expressions for the path where the artifact downloads and use that expressions instead , which could be used irrespective of the swimlane
There was a problem hiding this comment.
@piyush-bhuwalka we will run arifact collection as an independent plugin.
3 participants
No description provided.