Skip to content

Raise error on empty CA bundle value#410

Open
alexgromero wants to merge 1 commit into
boto:developfrom
alexgromero:fix/empty-ca-bundle-value
Open

Raise error on empty CA bundle value#410
alexgromero wants to merge 1 commit into
boto:developfrom
alexgromero:fix/empty-ca-bundle-value

Conversation

@alexgromero

Copy link
Copy Markdown
Contributor

Issue #, if available:

Description of changes:
When a CA bundle value (ca_bundle, AWS_CA_BUNDLE, REQUESTS_CA_BUNDLE, or the verify parameter) resolves to an empty string, create_s3_crt_client will now raise an error.

An empty string is not a valid value for these settings, which are defined as paths to a CA bundle.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@alexgromero
alexgromero requested a review from a team as a code owner July 18, 2026 00:37
@codecov-commenter

codecov-commenter commented Jul 18, 2026

Copy link
Copy Markdown

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

❌ Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 81.64%. Comparing base (8647a30) to head (2f35595).
⚠️ Report is 45 commits behind head on develop.

Files with missing lines Patch % Lines
s3transfer/crt.py 0.00% 3 Missing ⚠️
❗ Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #410      +/-   ##
===========================================
+ Coverage    80.28%   81.64%   +1.35%     
===========================================
  Files           16       16              
  Lines         3013     3187     +174     
===========================================
+ Hits          2419     2602     +183     
+ Misses         594      585       -9     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants