UpdateReboot with composefs disk image#97
Open
HarshwardhanPatil07 wants to merge 2 commits into
Open
Conversation
Ubuntu GHA runners ship registries.conf in the older INI-style (v1) format. Podman 5+ requires the TOML-based v2 format and rejects v1, causing podman operations to fail in CI. Overwrite the file with a minimal v2 registries.conf. Signed-off-by: HarshwardhanPatil07 <[email protected]>
Factor the TestUpdateReboot body into a shared testUpdateReboot helper and use a table-driven pattern to run it against both ostree and composefs disk images. Skip the composefs subtest when the env var is unset. A new WithNodeDiskImage NodeOption lets tests override the VM disk image passed as --node-image to bink node add. The Makefile derives BINK_NODE_DISK_IMAGE_COMPOSEFS from BINK_NODE_DISK_IMAGE by appending -composefs. Bump BINK_COMMIT to pick up the composefs cloud-init fix from bink. Closes: bootc-dev#74 Signed-off-by: HarshwardhanPatil07 <[email protected]>
HarshwardhanPatil07
changed the title
jlebon
approved these changes
Jul 9, 2026
jlebon
left a comment
jlebon
left a comment
Collaborator
There was a problem hiding this comment.
Will let Alice have a look for overall looks sane to me!
Comment on lines
+175
to
+179
| # Ubuntu runners ship a v1 (INI) registries.conf that Podman >= 5 | ||
| # rejects. Overwrite with a minimal v2 (TOML) config. | ||
| - name: Write v2 registries.conf | ||
| run: printf 'unqualified-search-registries = ["docker.io"]\n' | sudo tee /etc/containers/registries.conf | ||
|
|
Collaborator
There was a problem hiding this comment.
Or we could just... delete that file, no? Will podman fail if it's not present.
Anyway, minor/optional to be clear!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
UpdateReboot with Composefs disk image
Closes #74