Skip to content

Make the checkbox background overwritable #41

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
yvesh wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Make the checkbox background overwritable #41

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
867ecec
Make the checkbox background overridable
yvesh Nov 16, 2020
c24c038
Add dist files
ciar4n Nov 16, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions dist/bonsai-base.css
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion dist/bonsai-base.css.map
View file
Open in desktop

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion dist/bonsai-base.min.css
View file
Open in desktop

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion dist/bonsai-base.min.css.map
View file
Open in desktop

Large diffs are not rendered by default.

3 changes: 1 addition & 2 deletions dist/bonsai.css
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion dist/bonsai.css.map
View file
Open in desktop

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion dist/bonsai.min.css
View file
Open in desktop

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion dist/bonsai.min.css.map
View file
Open in desktop

Large diffs are not rendered by default.

3 changes: 1 addition & 2 deletions src/base/_forms.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -141,8 +141,7 @@ input[type="radio"] {

input[type="checkbox"]:checked,
input[type="radio"]:checked {
background: var(--primary);

background: var(--accent-bg, var(--primary));

@ciar4n ciar4n Dec 21, 2020

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think just --primary might be enough here. My only reason is that it might be best keeping accent variables assciated with the .accent class alone.

@yvesh yvesh Jan 2, 2021

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I agree --accent-bg was a fallback solution. It probably should be --element-bg?

}

input[type="checkbox"]:checked::before {
Expand Down