fix: return EOF when buffer is empty#472
Open
secDre4mer wants to merge 2 commits into
Open
Conversation
The bra reader could return invalid results when a read ended exactly so no data was left: In this case, the rc.rc read returned (0, EOF), rc.n was 0. Therefore the rc.buf.Read() was called with an empty slice, which caused it to return (0, nil), which was then returned to the caller, and left the reader in the same state as before. In combination with e.g. io.ReadAll, this could cause an endless loop.
Owner
|
Is there an archive available that demonstrates the problem so it can be added as a test case? |
Author
|
I'll upload a test. Please note that I don't own (or trust) that test data file; and I've noticed that reads on some other files in it fail, so it might even be partially invalid... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The bra reader could return invalid results when a read ended exactly so no data was left:
In this case, the rc.rc read returned (0, EOF), rc.n was 0.
Therefore the rc.buf.Read() was called with an empty slice, which caused it to return (0, nil).
This was then returned to the caller, and left the reader in the same state as before.
In combination with e.g. io.ReadAll, this could cause an endless loop.