Skip to content

Implement AAAA records#9

Open
GM-Alex wants to merge 9 commits into
bnfinet:masterfrom
GM-Alex:master
Open

Implement AAAA records#9
GM-Alex wants to merge 9 commits into
bnfinet:masterfrom
GM-Alex:master

Conversation

@GM-Alex

@GM-Alex GM-Alex commented Feb 9, 2015

Copy link
Copy Markdown

I implement AAAA records in a simple way, but it works like charm. I also adjust the bash script for building and running the container to use the source files instead of the git repository and remove double files.

Adjust bash script
Remove unnecessary files
@bnfinet

bnfinet commented Feb 10, 2015

Copy link
Copy Markdown
Owner

thanks for the contribution @GM-Alex, you beat me to it :)

it's going to take a few days for me to find the time to merge and test. If you had an opportunity to rebase and resubmit, it would be much appreciated.

Can I add you to the CONTRIBUTORS.txt file?

@GM-Alex

GM-Alex commented Feb 12, 2015

Copy link
Copy Markdown
Author

I don't get the rebase thing, did I miss some update and worked on an outdated version?

Sure can you add me to the contributor. ;)

@bnfinet

bnfinet commented Feb 12, 2015

Copy link
Copy Markdown
Owner

Hey Alex, there we a pull request which came in before yours which I merged, which means that now your changes won't merge without some manual intervention.

If you did happen to have an opportunity to pull and refactor I might suggest you split the work into multiple pulls to separate the concerns (move Dockerfile vs AAAA)

Thanks again for the good work. I expect to find some time in the coming days.

Alexander Schneider added 2 commits February 15, 2015 13:05
Conflicts:
	Dockerfile
	docker/build_docker.sh
	docker/run_docker.sh
@GM-Alex

GM-Alex commented Feb 15, 2015

Copy link
Copy Markdown
Author

Rebase done ;)

Alexander Schneider and others added 6 commits August 3, 2015 00:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants