Skip to content

test(uniswap): verify proposal 99 Robinhood fees - #99

Open
blockfulintern wants to merge 1 commit into
mainfrom
uni/proposal-99-robinhood
Open

test(uniswap): verify proposal 99 Robinhood fees#99
blockfulintern wants to merge 1 commit into
mainfrom
uni/proposal-99-robinhood

Conversation

@blockfulintern

Copy link
Copy Markdown
Contributor

Proposal summary

Extends Uniswap protocol-fee collection to Robinhood Chain by creating two Arbitrum Orbit retryable tickets. The L2 calls configure the v2 factory fee collector as the Robinhood TokenJar and transfer v3 factory ownership to the V3OpenFeeAdapter.

Calldata verification

  • PASS — call 0: 0x1A07cc4BD17E0118BdB54D70990D2158AbAD7a2D / createRetryableTicket (0x679b6ded), nesting IV2Factory.setFeeTo (0xf46901ed) for 0x2aC03e14Cfe755426DaAEe0a4994184Ce81482F8.
  • PASS — call 1: 0x1A07cc4BD17E0118BdB54D70990D2158AbAD7a2D / createRetryableTicket (0x679b6ded), nesting IV3Factory.setOwner (0x13af4035) for 0x05C420bC4823e039AA4dA645eDde743486dAAA25.
  • Both manually derived payloads match the live proposal calldata byte-for-byte.

Assertion results

  • Before: verifies the Ethereum Inbox is deployed, derives and checks the L2 Timelock alias, and checks the retryable-ticket fee formula (0.01 ETH + 200,000 × 0.1 gwei = 0.01002 ETH).
  • After: verifies the Governor consumes exactly 0.02004 ETH, the Timelock retains none of the pass-through ETH, and the Inbox emits exactly two delivered-message events.

Findings

  • CRITICAL: none.
  • IMPORTANT: none.
  • INFO: execution requires the caller to supply 0.02004 ETH to the payable Governor execution so both retryable tickets can be funded.

Recommendation

APPROVE

Verification

git clone https://github.com/blockful/dao-proposals.git
cd dao-proposals
git checkout b69d47c
MAINNET_RPC_URL=<archive-mainnet-rpc> forge test --match-path 'src/uniswap/proposals/99 - Protocol Fee Expansion Robinhood Chain/*' -vv

Local result: 1 passed, 0 failed.

ClickUp: https://app.clickup.com/t/86ajkrvdp
Proposal: https://anticapture.com/UNI/governance/proposal/99
Transaction: https://etherscan.io/tx/0x3a7421abc334d82f7da81512c182ac9c75d80007554b3c99cf3cc12b0758e176

@pikonha
pikonha requested a review from alextnetto July 20, 2026 13:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant