test(uniswap): verify proposal 99 Robinhood fees - #99
Open
blockfulintern wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposal summary
Extends Uniswap protocol-fee collection to Robinhood Chain by creating two Arbitrum Orbit retryable tickets. The L2 calls configure the v2 factory fee collector as the Robinhood TokenJar and transfer v3 factory ownership to the V3OpenFeeAdapter.
Calldata verification
0x1A07cc4BD17E0118BdB54D70990D2158AbAD7a2D/createRetryableTicket(0x679b6ded), nestingIV2Factory.setFeeTo(0xf46901ed) for0x2aC03e14Cfe755426DaAEe0a4994184Ce81482F8.0x1A07cc4BD17E0118BdB54D70990D2158AbAD7a2D/createRetryableTicket(0x679b6ded), nestingIV3Factory.setOwner(0x13af4035) for0x05C420bC4823e039AA4dA645eDde743486dAAA25.Assertion results
0.01 ETH + 200,000 × 0.1 gwei = 0.01002 ETH).0.02004 ETH, the Timelock retains none of the pass-through ETH, and the Inbox emits exactly two delivered-message events.Findings
0.02004 ETHto the payable Governor execution so both retryable tickets can be funded.Recommendation
APPROVE
Verification
Local result: 1 passed, 0 failed.
ClickUp: https://app.clickup.com/t/86ajkrvdp
Proposal: https://anticapture.com/UNI/governance/proposal/99
Transaction: https://etherscan.io/tx/0x3a7421abc334d82f7da81512c182ac9c75d80007554b3c99cf3cc12b0758e176