chore: trigger client build - #2094
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
1 Skipped Deployment
|
|
🚅 Deployed to the anticapture-pr-2094 environment in anticapture-infra
|
|
🔍 Vercel preview: https://anticapture-9cp91n0gs-ful.vercel.app |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: b1e2a4089b
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
|
||
| if (error) { | ||
| return <div className="text-primary p-4">Error: {error.message}</div>; | ||
| if (isProposalNotFoundError(error) || !proposal) { |
There was a problem hiding this comment.
When the proposal request fails with a non-404 error, such as a 500 response or network failure, the hook also returns no proposal, so !proposal selects this branch and incorrectly displays “Proposal not found.” The subsequent “Unable to load proposal” branch is therefore unreachable for normal request failures without cached data; classify error first and reserve the missing-proposal fallback for successful empty responses.
Useful? React with 👍 / 👎.
🎨 UI Review
Scope: Governance proposal list — vote progress barMust-fix — raw error text shown to users <BlankSlate title="Unable to load proposal" description={error.message} .../>
Nice-to-have — bar/marker size changed for every proposal, not just the new Snapshot ones Nice-to-have — same icon/tone for "not found" vs "failed to load" Validated — no change needed
MobileNo mobile-specific code in this diff; the progress bar and blank slate inherit existing responsive behavior from their parents — nothing new to check here. Scope noteThis is a UI-only review (visual fidelity, DS adherence, UX, copy) — architecture and hook/test structure are out of scope; the author has a code reviewer for that. Generated by Claude Code |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: ef5bd16966
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| const offchainQuorumPercentage = | ||
| totalOffchainVotes > 0 ? (offchainQuorum / totalOffchainVotes) * 100 : 0; |
There was a problem hiding this comment.
For a basic Snapshot proposal with a positive quorum but zero scores, this fallback sets the percentage to 0; hasOffchainQuorumMarker then evaluates true and renders the positive quorum threshold at the far-left 0% position. This misleadingly places the threshold as though no voting power were required, whereas proposals with some votes below quorum correctly hide the out-of-range marker. Treat the zero-total case as unreached and hide the marker.
Useful? React with 👍 / 👎.
2 participants
Note
Low Risk
Import-only reorder in codegen config; no logic, API, or security impact.
Overview
Reorders the
./src/generatorsimport list inkubb.config.tssomapEthereumFormatFakersis imported aftermapEthereumFormatTypesinstead of before it. No runtime or codegen behavior changes—same symbols, same Kubb plugin wiring.Reviewed by Cursor Bugbot for commit fecea54. Configure here.