feat: configure S3 URL addressing style - #3400
Open
kalvinnchau wants to merge 5 commits into
Open
Conversation
Add one strict path-or-virtual setting shared by media and Git/CAS storage. Preserve path-style MinIO defaults, validate bad values before startup, and document Railway and Helm configuration. Co-authored-by: npub122y0pqkertljmedu303rl0aqrj3w8pvu43t6jxm6875lzg6f2pwqegc3xc <5288f082d91aff2de5bc8be23fbfa01ca2e3859cac57a91b7a3fa9f12349505c@buzz.block.builderlab.xyz> Signed-off-by: npub122y0pqkertljmedu303rl0aqrj3w8pvu43t6jxm6875lzg6f2pwqegc3xc <5288f082d91aff2de5bc8be23fbfa01ca2e3859cac57a91b7a3fa9f12349505c@buzz.block.builderlab.xyz>
Honor shared URL addressing in the Git probe, expose the signing region through Helm, and make storage validation guidance match the actual startup probe behavior. Co-authored-by: Kalvin Chau <[email protected]> Signed-off-by: Kalvin Chau <[email protected]>
Co-authored-by: Kalvin Chau <[email protected]> Signed-off-by: Kalvin Chau <[email protected]>
kalvinnchau
marked this pull request as ready for review
July 28, 2026 23:21
kalvinnchau
changed the title
Keep Helm region wiring opt-in, align provider probes on the shared S3 variables, and document the bundled Compose storage contract accurately. Co-authored-by: Kalvin Chau <[email protected]> Signed-off-by: Kalvin Chau <[email protected]>
Make the default-region absence assertion match any environment entry so an unconditional BUZZ_S3_REGION render fails the chart test. Co-authored-by: Kalvin Chau <[email protected]> Signed-off-by: Kalvin Chau <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
BUZZ_S3_ADDRESSING_STYLE=path|virtualsetting shared by media and Git/CAS storageBest-practice rationale
AWS documents both URL forms and favors virtual-hosted addressing for S3, while compatibility endpoints such as the bundled MinIO deployment can require path style.
rust-s3defaults to virtual/subdomain addressing and provideswith_path_style()for the explicit compatibility case.Some providers buckets only support as virtual-hosted bucket styles. This PR therefore uses one explicit, provider-neutral switch rather than endpoint heuristics or fallback behavior, while retaining
pathas Buzz's backward-compatible default.Sources:
Validation
cargo fmt --allcargo check --workspace --all-targetsbuzz-mediaandbuzz-relayparsing/client-construction tests for defaults, strict errors, and both URL styles