Hide join and leave messages by default with a client-side setting - #3214
Open
joshfriend wants to merge 1 commit into
Open
Hide join and leave messages by default with a client-side setting#3214joshfriend wants to merge 1 commit into
joshfriend wants to merge 1 commit into
Conversation
Signed-off-by: Josh Friend <[email protected]>
joshfriend
force-pushed
the
hide-join-leave-messages
branch
from
July 28, 2026 14:39
19a48f9 to
552e608
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a device-local "Show join and leave messages" setting, hidden by default, controlling whether
member_joined,member_left, andmember_removedsystem rows render in channel timelines. One toggle covers all three row types on both desktop (localStorage) and mobile (SharedPreferences).This is purely client side. The relay still delivers the kind 40099 membership events so member lists stay live, only timeline rendering is filtered. The desktop toggle lives under Settings > Appearance in a new Messages section, and mobile has a matching Messages section in Settings.
Related issue
None found.
Testing
just desktop-check,just desktop-typecheck, andjust desktop-test(3675 passed) plusdart format,flutter analyze, and the fullflutter testsuite. New unit tests cover the desktop timeline filter, a mobile widget test covers the filtered timeline, and a Playwright screenshot spec (tests/e2e/join-leave-visibility-screenshots.spec.ts) produced the shots below so they can be regenerated. Mobile screenshots are not included, the mobile toggle mirrors the desktop behavior and is covered by widget tests.The new toggle under Settings > Appearance, off by default:
Default timeline: a join, an add, and a leave were posted between these two messages but no system rows render:
Same timeline with the setting enabled: