fix(mobile): tag DM recipients on send - #2863
Conversation
b58c4ab to
8c77451
Compare
Include DM participants in outgoing mobile p-tags while preserving explicit mention handling and thread/media tag order. Closes block#2835 Signed-off-by: Konstantin Baltsat <[email protected]>
3dc0c48 to
af2216f
Compare
Independent reviewI checked this out at
The send-path wiring covers both the channel composer and DM thread composer, and the regression tests correctly cover plain DMs, self exclusion/deduplication, non-DM behavior, and threaded tag ordering. One consistency fix is worth folding in before merge: |
|
Closing this in favor of #3258, which now covers the same recipient-tag behavior at the central send path with dedicated wire tests. Keeping both implementations open would duplicate review effort. Thanks for the review and guidance here. |
Summary
Mobile DM sends only serialized
ptags from picker-resolved mentions, so a plain DM could reach the relay without addressing the counterparty. This adds the known DM participants to the existing mention-normalization path.Changes
h, threadetags, recipientptags, then media tagsVerification
dart format --output=none --set-exit-if-changedon all four changed filesgit diff --checkAI assistance: ChatGPT/Codex was used for implementation. The generated patch was independently reviewed, corrected, and reduced to one product commit before publication.
Closes #2835